Review Request 127260: Experiment: cache svg icons from icon theme

[Marco Martin]

> On March 4, 2016, 8:52 p.m., David Edmundson wrote:
> > Given how many troubles we've had (and still have) with caches I'd love to see a thorough auto unit test before merging.
> > 
> > It seems a bit odd to share the cache file with the plasma theme SVG cache given the source is different. 
> > 
> > I have a feeling that you'll discard the cache, then immediately load the same KImageCache file and as the name (which is based on plasma theme number) hasn't changed just reload the same old thing again.

the cache is the same, because even if the source of the svg is different, the icons are colored according the current plasma theme


> On March 4, 2016, 8:52 p.m., David Edmundson wrote:
> > src/plasma/private/theme_p.cpp, line 231
> > <https://git.reviewboard.kde.org/r/127260/diff/2/?file=447948#file447948line231>
> >
> >     can you rely on the metadatafile being touched if icons update?
> >     
> >     For .deb packages it's fine, but with delta RPMs, I'm not sure if it's true?

then will need icon metadata manually updating version as well :/


> On March 4, 2016, 8:52 p.m., David Edmundson wrote:
> > src/plasma/private/theme_p.cpp, line 233
> > <https://git.reviewboard.kde.org/r/127260/diff/2/?file=447948#file447948line233>
> >
> >     I'm not sure this works.
> >     This compares if the cache file > icon file.
> >     
> >     This is a shared cache; both in terms of a file and mmapd memory.
> >     so what happens when you run krunner and plasmashell at the same time when you upgrade and you change icons -  one will update, the other won't.

hmm, i'm monitoring also kicontheme signals as well for runtime changes, both processes should get it, no?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/#review93174
-----------------------------------------------------------


On March 4, 2016, 11:04 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127260/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 11:04 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this attempts to cache as well svg icons from the icon theme (invalidating as well when the icon theme is updated)
> 
> still to be done, to figure out to invalidate cache when the icon theme is changed in the two cases:
> * theme changed with plasmashell running
> * theme changed with plasma shell not running
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/theme_p.h 69a8934 
>   src/plasma/private/theme_p.cpp 943d3af 
>   src/plasma/svg.cpp ccd248a 
> 
> Diff: https://git.reviewboard.kde.org/r/127260/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160307/a743a5bb/attachment-0001.html>