Review Request 127301: Disable window move on Wayland due to lack of Qt features and some cleanup
Martin Gräßlin
mgraesslin at kde.org
Mon Mar 7 10:35:18 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127301/
-----------------------------------------------------------
Review request for Plasma and Hugo Pereira Da Costa.
Repository: breeze
Description
-------
A call to QX11Info::isPlatformX11() is a string comparison each time.
So let's better have the value cached, it won't change at runtime.
[kstyle] Add static bool Helper::isWayland()
Just like isX11.
[kstyle] Disable window move on Wayland
Unfortunately we cannot support moving windows from the style on Wayland
(yet). To move a window we need the (Xdg)ShellSurface and the wl_seat.
Through the integration plugin we can get the ShellSurface, but not the
seat. Thus we cannot invoke the feature through KWayland.
We either need to extend the native interface and/or extend QWindow to
expose a startSystemMove (QPlatformWindow already supports a
startSystemResize).
Diffs
-----
kstyle/breezehelper.h 16344687463d2955b51d9244b7c8990e88a28b5f
kstyle/breezehelper.cpp 1c35f25fd19060fc74d052493f1303a74099b308
kstyle/breezewindowmanager.cpp a2d5bca223722ed658aea0c7ba6ea1ffc0817c7d
Diff: https://git.reviewboard.kde.org/r/127301/diff/
Testing
-------
Thanks,
Martin Gräßlin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160307/972243bf/attachment.html>
More information about the Plasma-devel
mailing list