Review Request 127086: Raise the required CMake version to 3.4.0

[Elias Probst]

> On March 6, 2016, 6:43 p.m., Pino Toscano wrote:
> > Commit 09e58f7f33658fec6291213636989c715b32b7e2 should fix the build with older CMake; please check whether it does for you as well.
> > 
> > In any case, -1 to this change.

@Pino: Thanks a lot - closing this one.


- Elias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127086/#review93239
-----------------------------------------------------------


On Feb. 16, 2016, 11:13 a.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127086/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 11:13 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Since fea67bd2 plasma-workspace requires CMake >= 3.4.0 as
> pkg_get_variable used in cmake/FindIsoCodes.cmake isn't available in previous
> releases.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c2debaa3aeb24b4da9918642b8931002c205d228 
> 
> Diff: https://git.reviewboard.kde.org/r/127086/diff/
> 
> 
> Testing
> -------
> 
> Updated from CMake 3.3.1 to 3.4.3 and cmake/FindIsoCodes.cmake succeeded.
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160306/19563997/attachment.html>