Review Request 127295: Don't hardcode path to Plymouth theme directory

Harald Sitter sitter at kde.org
Sun Mar 6 13:13:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127295/#review93233
-----------------------------------------------------------


Ship it!




Ship It!

- Harald Sitter


On March 6, 2016, 12:06 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127295/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: breeze-plymouth
> 
> 
> Description
> -------
> 
> On Fedora Plymouth themes are installed in /usr/share/plymouth/themes, so the theme did not work because breeze.plymouth has hardcoded path to /lib/plymouth/themes.
> 
> With this patch we replace the paths in breeze.plymouth with value of $Plymouth_THEMESDIR at build time.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 67f4b1d 
>   breeze/CMakeLists.txt PRE-CREATION 
>   breeze/breeze.plymouth d31431e 
>   breeze/breeze.plymouth.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127295/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160306/69c09e48/attachment.html>


More information about the Plasma-devel mailing list