Review Request 127277: ContainmentInterface: Fix use of QRect right() and bottom()

[David Rosca]

> On March 4, 2016, 4:29 p.m., Marco Martin wrote:
> > yep, the patch is correct...
> > +1 for adding a test tough

I'm for adding test too, but there are currently no tests in plasma-workspace and also I think it won't be easy to test it. So maybe a good thing to look into during sprint next week.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127277/#review93168
-----------------------------------------------------------


On March 4, 2016, 3:26 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127277/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 3:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> right() = x() + width() - 1
> bottom() = y() + height() - 1
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 845bb4d 
> 
> Diff: https://git.reviewboard.kde.org/r/127277/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160304/89f76d83/attachment.html>