Review Request 127270: Remove effectively duplicate code path for handling QPixmaps
David Edmundson
david at davidedmundson.co.uk
Thu Mar 3 18:28:40 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127270/
-----------------------------------------------------------
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
-------
IconItem handled both QOixmaps and QImages as a source.
QVariant(somePixmap).canConvert<QImage>() returns true so one of the
two code paths isn't executed. Given converting between the two is
practically free, we don't need two code paths.
Diffs
-----
src/declarativeimports/core/iconitem.cpp 1e98e4952656756bf320c8974e075441590fad4f
Diff: https://git.reviewboard.kde.org/r/127270/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160303/5d820695/attachment-0001.html>
More information about the Plasma-devel
mailing list