Review Request 127268: Docs for IconItem
Kai Uwe Broulik
kde at privat.broulik.de
Thu Mar 3 18:12:30 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127268/#review93113
-----------------------------------------------------------
src/declarativeimports/core/iconitem.h (line 48)
<https://git.reviewboard.kde.org/r/127268/#comment63491>
Perhaps mention when QIcon has iconName set it will use that
src/declarativeimports/core/iconitem.h (line 64)
<https://git.reviewboard.kde.org/r/127268/#comment63492>
"Typically used to indicate that it is hovered"
src/declarativeimports/core/iconitem.h (line 85)
<https://git.reviewboard.kde.org/r/127268/#comment63493>
IconItem actually enforces square icons in various places in the code which needs fixing and is the reason thumbnails on the desktop are sqaure no matter their original size
- Kai Uwe Broulik
On März 3, 2016, 5:36 nachm., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127268/
> -----------------------------------------------------------
>
> (Updated März 3, 2016, 5:36 nachm.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Wrote some docs whilst waiting for something else.
>
>
> Diffs
> -----
>
> src/declarativeimports/core/iconitem.h a8f2cdb6f10fb762b8e2d3ed99c2650084147657
>
> Diff: https://git.reviewboard.kde.org/r/127268/diff/
>
>
> Testing
> -------
>
> None.
> It's docs.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160303/89377b11/attachment-0001.html>
More information about the Plasma-devel
mailing list