Review Request 127260: Experiment: cache svg icons from icon theme

[Marco Martin]

> On March 2, 2016, 11:48 p.m., David Edmundson wrote:
> > why would someone load an icon as an SVG and not use IconItem?

there is somebody loading icons as SVG and not using IconItem and it is wait for it... IconItem :p
jokes aside, i think this should be done at the lowest level this things happen, no?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/#review93079
-----------------------------------------------------------


On March 2, 2016, 3:44 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127260/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 3:44 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this attempts to cache as well svg icons from the icon theme (invalidating as well when the icon theme is updated)
> 
> still to be done, to figure out to invalidate cache when the icon theme is changed in the two cases:
> * theme changed with plasmashell running
> * theme changed with plasma shell not running
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/theme_p.h 69a8934 
>   src/plasma/private/theme_p.cpp 943d3af 
>   src/plasma/svg.cpp ccd248a 
> 
> Diff: https://git.reviewboard.kde.org/r/127260/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160303/d8db5869/attachment.html>