Review Request 127257: about-distro: Fix build with kcoreaddons < 5.20

Martin Gräßlin mgraesslin at kde.org
Wed Mar 2 12:32:01 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127257/#review93070
-----------------------------------------------------------


Ship it!




Ship It!

- Martin Gräßlin


On March 2, 2016, 1:24 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127257/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 1:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> The KCoreAddons header was introduced with 5.20 and
> 839900875b266ec85c10167b48fe3988fde8b8da already #ifdefs its newly
> added functionality, just not that header.
> 
> 
> Diffs
> -----
> 
>   Modules/about-distro/src/Module.cpp 72ac2ca60a1750e79b5273da4274d534d3f1ddfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127257/diff/
> 
> 
> Testing
> -------
> 
> Built successfully against kcoreaddons-5.19.0
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160302/648e6a8e/attachment.html>


More information about the Plasma-devel mailing list