Review Request 127258: drkonqi: Fix build with kcoreaddons < 5.20

Marco Martin notmart at gmail.com
Wed Mar 2 12:31:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127258/#review93068
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On March 2, 2016, 12:26 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127258/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 12:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The KCoreAddons header was introduced with 5.20 and
> 0fa4ba8479ceb4fe1e139f6d3650e97fe56bbf38 already #ifdefs its newly
> added functionality, just not that header.
> 
> 
> Diffs
> -----
> 
>   drkonqi/systeminformation.cpp 6f3d07c688421db5a8cf30a66dc0b3261fc69081 
> 
> Diff: https://git.reviewboard.kde.org/r/127258/diff/
> 
> 
> Testing
> -------
> 
> Built successfully against kcoreaddons-5.19.0
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160302/a2cc1e4b/attachment.html>


More information about the Plasma-devel mailing list