Review Request 127254: Fix showing openGL compatability warning to user

David Edmundson david at davidedmundson.co.uk
Wed Mar 2 10:31:54 UTC 2016



> On March 2, 2016, 7:03 a.m., Martin Gräßlin wrote:
> > shell/shellcorona.cpp, line 1722
> > <https://git.reviewboard.kde.org/r/127254/diff/1/?file=447843#file447843line1722>
> >
> >     qCritical or qCCritical?

None of the rest of this class is.

I'll try and do that for all the shell as a new commit.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127254/#review93054
-----------------------------------------------------------


On March 2, 2016, 1:33 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127254/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 1:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Make use of Qt5.5 API QQuickWindow::sceneGraphError rather than catching
> the errors in a message filter.
> 
> I also merged with existing warning where contexts could be created, but
> compiling shaders would not work.
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp d9963aa06c1a60eaac7d4027b7bdadeba34716ff 
>   shell/shellcorona.cpp 667bb8dc53db051d97d0dd699c2ea3cc3ff76ca7 
> 
> Diff: https://git.reviewboard.kde.org/r/127254/diff/
> 
> 
> Testing
> -------
> 
> Compiles...
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160302/a06ca334/attachment-0001.html>


More information about the Plasma-devel mailing list