Review Request 127229: Workaround bug 352055

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127229/#review93048
-----------------------------------------------------------



https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=42849c35780577cd9c7bd248b3086ebdfcd965df

There. I think we need a 5.5.5 respin, this is a serious regression. Please be careful next time when rushing in such changes...

- Kai Uwe Broulik


On März 1, 2016, 4:23 nachm., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127229/
> -----------------------------------------------------------
> 
> (Updated März 1, 2016, 4:23 nachm.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 352055
>     https://bugs.kde.org/show_bug.cgi?id=352055
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> From my debug, the real problem is that the model value in qml some times can have wrong value. When there is the "empty" space in systray, model.index obtained from delegate is -1 and no any other data is available, which should never happens.
> 
> This is obviously a bug in Qt.. but unfortunately I have no simple test case to reproduce it.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/tasklistmodel.cpp 1fa306c 
> 
> Diff: https://git.reviewboard.kde.org/r/127229/diff/
> 
> 
> Testing
> -------
> 
> Works for me at least.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160301/5b8cc80f/attachment-0001.html>