Review Request 127247: [Icon Widget] Add shadow instead of background
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Mar 1 20:03:38 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127247/#review93036
-----------------------------------------------------------
Maybe get the DropShadow on the icon as well?
- Aleix Pol Gonzalez
On March 1, 2016, 8:43 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127247/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 8:43 p.m.)
>
>
> Review request for Plasma, KDE Usability and Eike Hein.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Copied from FolderView, makes the icon significantly less intrusive.
>
>
> Diffs
> -----
>
> applets/icon/package/contents/ui/main.qml 2ba8dc8
>
> Diff: https://git.reviewboard.kde.org/r/127247/diff/
>
>
> Testing
> -------
>
> Beautiful!
>
> (On RB rather than Phab as Phab's only way to add screenshots is via drag and drop which is broken from Qt 5 to Chrome)
>
>
> File Attachments
> ----------------
>
> Before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/01/d13644f3-287d-4a19-92d8-0a10a350fec6__Screenshot_20160301_203354.png
> After
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/01/a9d6fd79-ddf0-4dec-8375-7bac2cca5efa__Screenshot_20160301_204009.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160301/d43b3671/attachment.html>
More information about the Plasma-devel
mailing list