[Differential] [Request, 3 lines] D2054: Fix for bug 364530
chinmoyr (Chinmoy Ranjan Pradhan)
noreply at phabricator.kde.org
Thu Jun 30 15:59:04 UTC 2016
chinmoyr created this revision.
chinmoyr added reviewers: sebas, bshah, Plasma.
chinmoyr added a subscriber: Plasma.
chinmoyr set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
chinmoyr added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In plasma-workspace the prepareUDSEntry in file kioslave/desktop/kio_desktop.cpp sets UDS_TARGET_URL as
'//entry.insert(KIO::UDSEntry::UDS_TARGET_URL, entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)//'.
Now using UDS_LOCAL_PATH will return the path without file scheme. This schemeless path will be set in UDS_TARGET_URL and then will be used by
kio's //targetUrl //and then final passed to //Krun// where it will fail the scheme test eventually leading to the said bug.
What this patch will do is simply create a url using //QUrl::fromLocalFile// and then pass the //url.toString()//'s result to //insert//. This way the bug won't occur.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2054
AFFECTED FILES
new:kioslave/desktop/kio_desktop.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: chinmoyr, sebas, bshah, #plasma
Cc: plasma-devel, #plasma, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160630/2d0ccf77/attachment.html>
More information about the Plasma-devel
mailing list