[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

[bshah (Bhushan Shah)]

bshah added a comment.


  Some minor issues I noticed..

INLINE COMMENTS

> CMakeLists.txt:13
> +  Qt5::Quick
> +  KF5::WaylandClient
> +  KF5::WaylandServer

Not required, you just use WaylandServer API.

> kwinplugin.h:1
> +#ifndef KWINPLUGIN_H
> +#define KWINPLUGIN_H

This and all other header and C++ files are missing license headers,

See: https://community.kde.org/Policies/Licensing_Policy

> kwinqml.cpp:29-31
> +    if (!m_socketName.isNull() && !m_socketName.isEmpty()) {
> +    m_display->setSocketName(m_socketName);
> +    }

Coding style.

> kwinqml.h:1
> +#include <QtQuick/QQuickItem>
> +#include <QObject>

You are missing include guard in this header file.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160629/d33e26f2/attachment-0001.html>