Review Request 128300: Set Tooltip window type on ToolTipDialog through KWindowSystem API

[Anthony Fieroni]

> On Юни 28, 2016, 2:47 след обяд, David Edmundson wrote:
> > src/declarativeimports/core/tooltipdialog.cpp, line 122
> > <https://git.reviewboard.kde.org/r/128300/diff/1/?file=470078#file470078line122>
> >
> >     we already have setFlags(Qt::Tooltip)
> >     
> >     why is this not enough?
> 
> Martin Gräßlin wrote:
>     This depends on https://phabricator.kde.org/D2031
>     
>     Wayland doesn't have a window type "Tooltip". Thus Qt doesn't do anything with the flag. It's just being ignored. We need to manually do this by creating a PlasmaShellSurface, like with all other custom window types we have but Wayland doesn't. Like OSD, Notification, Panel, Dock. By using KWindowSystem it's just the easiest way.

How pure Qt apps will show tooltip in Wayland?


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128300/#review96911
-----------------------------------------------------------


On Юни 28, 2016, 2:43 след обяд, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128300/
> -----------------------------------------------------------
> 
> (Updated Юни 28, 2016, 2:43 след обяд)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> In order to have support for tooltip window type in Wayland, the
> window type NET::Tooltip is also set through KWindowSystem API once
> the platform surface is created.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltipdialog.cpp 18aa520bf15e1a03eb6a4816e49ab35e2350f8da 
> 
> Diff: https://git.reviewboard.kde.org/r/128300/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160628/374fc3f8/attachment.html>