Review Request 128301: [Containment] Treat HiddenStatus as low status
David Edmundson
david at davidedmundson.co.uk
Tue Jun 28 13:09:27 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128301/#review96914
-----------------------------------------------------------
>Doesn't work with system tray but that's because it has its own popup and thus Plasma doesn't know that it's accepting input. I couldn't figure out how to make it work, though. I tried Plasmoid.status in the container and then a property about when the dialog is open but it just wouldn't work :(
FYI I'm fixing that now.
- David Edmundson
On June 28, 2016, 1:04 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128301/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 1:04 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> The containment's status is the max of all applets.
>
> Unfortunately, HiddenStatus, while semantically lower, has the highest value so as soon as there's a hidden applet (eg. pager with just one virtual desktop), the panel will always auto-hide even when popups are open as its status will be HiddenStatus.
>
>
> Diffs
> -----
>
> src/plasma/private/containment_p.cpp a72bb56
>
> Diff: https://git.reviewboard.kde.org/r/128301/diff/
>
>
> Testing
> -------
>
> Not Bug 364847 but noticed it because of that.
>
> Doesn't work with system tray but that's because it has its own popup and thus Plasma doesn't know that it's accepting input. I couldn't figure out how to make it work, though. I tried Plasmoid.status in the container and then a property about when the dialog is open but it just wouldn't work :(
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160628/80670ae5/attachment.html>
More information about the Plasma-devel
mailing list