[Differential] [Request, 36 lines] D2033: Ignore idle timeout when session isn't active
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Tue Jun 28 11:40:42 UTC 2016
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPOWERDEVIL Powerdevil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When we become the active session we already simulate user activity but we still get delivered any pending idle timeouts before even that causing us to send the computer to sleep when switching to an idle session.
BUG: 354250
FIXED-IN: 5.7.0
TEST PLAN
Separate changes include:
- m_pendingResumeFromIdleActions becomes a QSet so save the if (!contains) { append } dance
- iterate over pendingResumeFromIdleActions and then clear the whole thing afterwards rather than erasing-while-iterating, might help Bug 345618
- Using auto for iterator names
Testing done:
- Let my session idle, screen dimmed, moved mouse, screen brightened again
- Switched to other session, waited for the timeout on the other session, switched back, screen did not dim (previously would do that and eventually suspend)
- Switched to other session, waited for timeout, switched back, screen did not dim, did not touch the mouse during that, screen eventually dimmed as it should (but not immediately after switching)
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D2033
AFFECTED FILES
daemon/powerdevilcore.cpp
daemon/powerdevilcore.h
daemon/powerdevilpolicyagent.cpp
daemon/powerdevilpolicyagent.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160628/74213db7/attachment-0001.html>
More information about the Plasma-devel
mailing list