[Differential] [Request, 42 lines] D2026: [platforms/drm] If mapping a DrmBuffer for a cursor fails, fallback to software cursor

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Tue Jun 28 08:26:44 UTC 2016


graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  So far the drm platform did not verify whether creating and mapping a
  DrmBuffer for a cursor works. This could result in a crash in the worst
  case.
  
  This change verfies whether mapping the two cursor buffers works, if
  not software cursor is enabled. The code is adjusted to ensure that
  none of the cursor buffers is accessed in case software cursor are
  enabled.
  
  Please note that right now the drm platform's rendering does not
  support software cursors. Thus currently this change results in no
  cursor at all. This will be addressed by following patches.
  
  BUG: 364740
  FIXED-IN: 5.7

TEST PLAN
  Verfied that it properly falls back to software cursor,
  but could not verify that the crash is actually fixed.

REPOSITORY
  rKWIN KWin

BRANCH
  drm-software-cursor-5.7

REVISION DETAIL
  https://phabricator.kde.org/D2026

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160628/5a868e3a/attachment.html>


More information about the Plasma-devel mailing list