[Differential] [Request, 3 lines] D2010: On Wayland never try to create a WindowPixmap from an X11 pixmap
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Sun Jun 26 14:29:59 UTC 2016
graesslin created this revision.
graesslin added reviewers: Plasma on Wayland, KWin.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
Our Wayland compositors cannot composite an X11 pixmap. Thus even
if we succeed in creating the pixmap, the changes would not get to
the scene. The code allowed for situation where a surface is not yet
set to fall back to the X11 code path. This can happen for XWayland
windows.
TEST PLAN
Crash in xclipboardsynctest without the change
REPOSITORY
rKWIN KWin
BRANCH
window-pixmap-wayland-always-5.7
REVISION DETAIL
https://phabricator.kde.org/D2010
AFFECTED FILES
scene.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma_on_wayland, #kwin
Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160626/6e08cda1/attachment.html>
More information about the Plasma-devel
mailing list