[Differential] [Updated, 772 lines] D1976: Image of the Day wallpaper plugin

bgupta (Boudhayan Gupta) noreply at phabricator.kde.org
Thu Jun 23 15:29:39 UTC 2016


bgupta changed the visibility from "All Users" to "Public (No Login Required)".
bgupta updated this revision to Diff 4689.
bgupta added a comment.


  I've addressed all of the issues except for layout and alignment in the configuration dialog.
  
  I'm soliciting feedback for all the outstanding issues, and the following:
  
  - I have no idea where `formAlignment` is set, but it's coming somewhere from within Plasma, and it makes things line up with the wallpaper type and layout fields above. How would I change things to ensure things still line up properly?
  - As for handling text overflow, should I just change the strings to something smaller?

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1976?vs=4678&id=4689

REVISION DETAIL
  https://phabricator.kde.org/D1976

AFFECTED FILES
  wallpapers/CMakeLists.txt
  wallpapers/iotd/CREDITS
  wallpapers/iotd/README
  wallpapers/iotd/contents/assets/bing.svg
  wallpapers/iotd/contents/assets/default.svg
  wallpapers/iotd/contents/assets/nasa.svg
  wallpapers/iotd/contents/assets/unsplash.svg
  wallpapers/iotd/contents/config/main.xml
  wallpapers/iotd/contents/ui/config.qml
  wallpapers/iotd/contents/ui/main.qml
  wallpapers/iotd/contents/ui/sources.js
  wallpapers/iotd/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bgupta, sebas, #plasma
Cc: garg, sebas, graesslin, davidedmundson, plasma-devel, #plasma, jensreuterberg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160623/9c1bb034/attachment.html>


More information about the Plasma-devel mailing list