[Differential] [Updated] D1976: Image of the Day wallpaper plugin

[bgupta (Boudhayan Gupta)]

bgupta marked 2 inline comments as done.
bgupta added a subscriber: garg.
bgupta added inline comments.

INLINE COMMENTS

> sebas wrote in config.qml:178
> So it will at most switch every 15 minutes? Seems a bit long as minimal value to me...

Note that we're hitting APIs, some of which have limits. Unsplash, for example, has a limit of 5000 API requests per hour. Pixabay (which I'm planning to add and have gotten an API key for) has even less and it's per application key, not per IP address.

> davidedmundson wrote in config.qml:237
> Not in the config.
> 
> We have this situation where we use Plasma Components in plasmoids, QtQuick.Controls in settings.
> 
> Heading inherits Plasma.Label - which potentially means the wrong font and more importantly wrong font colour which could be a white on white situation.
> 
> (Kirigami's headers should fix this at least)

Closing as per @davidedmundson's suggestion

> davidedmundson wrote in config.qml:246
> these don't update the apply button

They do on mine, but @garg has also reported the same errors. Any ideas?

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D1976

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bgupta, #plasma, sebas
Cc: garg, sebas, graesslin, davidedmundson, plasma-devel, #plasma, jensreuterberg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160623/7f886bd1/attachment-0001.html>