Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

[Thomas Pfeiffer]

> On April 28, 2016, 8:35 a.m., Thomas Pfeiffer wrote:
> > Thank you for providing a screenshot!
> > 
> > Now I just need to understand what problem this applet is supposed to solve.
> > The original problem Sebas wanted to solve was that "Show Desktop" hid the panel. That has been fixed in Show Desktop.
> > 
> > What problem does Show Desktop still have which this applet tries to solve?
> 
> Anthony Fieroni wrote:
>     For me there's no problem. I was asked from users to make this applet available, because it was present on KaOS with Sebas' diff, but with 5.6 this diff was incompatible. So i posted it on kde-look http://kde-look.org/content/show.php?action=content&content=175817 Compilation can be problem for normal users so Sebas ask me to return it at home. That's it :)
> 
> Andrey Bondrov wrote:
>     In fact, "Show Desktop" just shows desktop while many users want to minimize all windows (and then maximize one of them, not all). These users don't really want to see their desktop.

If indeed many users want exactly that, then that applet is indeed useful.
Please change the tooltip to just "Minimize all windows", then, because showing the desktop is not the goal of this.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127651/#review94945
-----------------------------------------------------------


On April 28, 2016, 8:11 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127651/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 8:11 a.m.)
> 
> 
> Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian Kügler.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt e591c81 
>   applets/minimizeall/CMakeLists.txt PRE-CREATION 
>   applets/minimizeall/Messages.sh PRE-CREATION 
>   applets/minimizeall/package/contents/config/main.xml PRE-CREATION 
>   applets/minimizeall/package/contents/ui/main.qml PRE-CREATION 
>   applets/minimizeall/package/metadata.desktop PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION 
>   applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION 
>   applets/minimizeall/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127651/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160428_110625.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2dc7f4c9-c10a-4166-95d7-67418ad9ce7f__Screenshot_20160428_110625.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160623/33a44d6c/attachment-0001.html>