[Differential] [Request, 237 lines] D1980: Don't crash if a decoration doesn't get created

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added reviewers: Plasma on Wayland, KWin.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  With the NoBorder option set the DecorationBridge won't create
  decorations. Thus we get a nullptr and obviously should not call
  into it. There was already a check for whether decoration is null,
  so that is a rather embarrassing bug.

TEST PLAN
  Test case added which exposes the crash

REPOSITORY
  rKWIN KWin

BRANCH
  dont-crash-no-border-5.7

REVISION DETAIL
  https://phabricator.kde.org/D1980

AFFECTED FILES
  autotests/wayland/CMakeLists.txt
  autotests/wayland/dont_crash_no_border.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin
Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160623/d3202385/attachment.html>