Review Request 128263: Don't include embedded contrainers in containmentAt(pos) - fix crash when adding a system tray.

David Edmundson david at davidedmundson.co.uk
Tue Jun 21 12:54:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128263/
-----------------------------------------------------------

(Updated June 21, 2016, 12:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

Do to so means the System Tray applet ends up being placed inside the
system tray container. This causes a recursive parent loop, creating a stack
overflow every time parent() is called recursively

This happens whenever one drags a sys tray on the desktop or simply adds
a new system tray whilst running.

BUG: 361777

We also need to do a hack for Plasma/5.7 in plasma-desktop somehow in
all cases where this is used as this is a huge bug.


Diffs
-----

  src/scriptengines/qml/plasmoid/containmentinterface.cpp db77db9abeafa508dd26c23710a657584ad1ef0b 

Diff: https://git.reviewboard.kde.org/r/128263/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160621/2651e2c4/attachment.html>


More information about the Plasma-devel mailing list