Review Request 128216: [QueryMatch] Add iconName

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128216/
-----------------------------------------------------------

(Updated June 17, 2016, 12:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 0314c4d16ecff82f75a97d0bf8c0ef5ed29673f3 by Kai Uwe Broulik to branch master.


Repository: krunner


Description
-------

This adds methods taking an iconName instead of a full-fledged QIcon. It reduces the likelihood of QIcon-related multithreading issues but also significantly speeds up KRunner by doing the icon lookup only in the view and only for icons that we actually display.


Diffs
-----

  src/querymatch.h 972ef83 
  src/querymatch.cpp 474e3ac 

Diff: https://git.reviewboard.kde.org/r/128216/diff/


Testing
-------

Usin krunner feels a billion times faster now (I adjusted all runners to use the new api where sensible)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160617/89ea1305/attachment.html>