[Differential] [Commented On] D1920: Add a LauncherUrlWithoutIcon data role as a speed optimization.

[dfaure (David Faure)]

dfaure added inline comments.

INLINE COMMENTS

> tasksmodel.cpp:357
>                              || (launcherUrl.isValid() && launcherUrlsMatch(launcherUrl,
> -                            launcherIndex.data(AbstractTasksModel::LauncherUrl).toUrl(), IgnoreQueryItems))) {
> +                            launcherIndex.data(AbstractTasksModel::LauncherUrlWithoutIcon).toUrl(), IgnoreQueryItems))) {
>                              launcherTasksModel->dataChanged(launcherIndex, launcherIndex);

Is IgnoreQueryItems still needed, now that both URLs are without icon data?

(or could there potentially be other query items in the future?)

> xwindowtasksmodel.cpp:656
>  
> -    if (!data.icon.name().isEmpty()) {
> +    if (!data.icon.name().isEmpty() || !encodeFallbackIcon) {
>          return data.url;

You could swap the two conditions, for a femto-second speed improvement in the common case.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1920

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, dfaure, davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160617/02b21419/attachment.html>