[Differential] [Request, 19 lines] D1916: [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Thu Jun 16 14:36:03 UTC 2016


broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The current approach of matching the MPRIS DBus interface suffix was a bit short-sighted. This patch makes it use the DesktopEntry provided by the application which should make it work with most players.
  
  I don't know what implications connecting to all sources has but given task manager only creates one ToolTipDelegate at a time and you usually only have one player running anyway, shouldn't be too bad.

TEST PLAN
  I can now control players I could not control previously

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1916

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160616/1ff9499c/attachment.html>


More information about the Plasma-devel mailing list