[Differential] [Updated] D1895: Finish implementation of mode in which launchers are not kept separate.

[hein (Eike Hein)]

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in tasksmodel.cpp:544
> Sure this logic is the right way round?
> 
> (I'm not convinced it's wrong either, I'm just confused)
> 
> at the start of the function:
> 
> insertPos is the right most launcher
> we iterate i from 0 to size getting from concatProxy
> if we find a window we move it to be next to the launcher, potentially
> 
> 1. Should that not be  if (i > insertPos) ++insertPos
> 2. we don't want to increment i if we've moved something to be below i, as we'd miss an item.
> 
> Might be better to iterate i backwards like hte other loop.

Was broken, should be good now!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  blblblbl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1895

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, mart
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160615/d38d96de/attachment-0001.html>