[Differential] [Request, 6 lines] D1898: [Kicker] Use KRun::runService instead of new KRun

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, hein, dfaure.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  "new KRun" is only meant to run absolute file paths and so breaks when we get a     
  service with relative entryPath() like when finding a KCModule.
  
  The tempFile argument causes this call to be asynchronous as to not block the UI

TEST PLAN
  The tempFile hack has David Faure's blessing as new KRun is only meant for when opening files and the like. KRun::runService normally blocks but doesn't when we do the tempFiles thing. This fixes opening eg KCMs (search for eg "Splash" and add it to favorites).
  
  - Opening apps in favorites still works
  - Opening apps in recent docs still works
  - OPening docs in recent docs still works
  - Opening apps in apps still works
  - Opening KCMs in favorites now works
  - Opening KCMs in recent docs now works

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1898

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/recentusagemodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160615/e3dcae4f/attachment.html>