[Differential] [Request, 5 lines] D1890: Fix crash on kquitapp/logout

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Wed Jun 15 13:01:10 UTC 2016


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  qDeleteAll will iterate through containments() however this is
  dynamically changing the list we're iterating through.
  
  Particularly bad is deleting the panel might delete the system tray
  containment, leading to a double delete on a now dangly pointer.

TEST PLAN
  kquitapp5 plasmashell. No crash

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1890

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160615/6210e676/attachment.html>


More information about the Plasma-devel mailing list