[Differential] [Changed Subscribers] D1866: Use QVector and QLatin1String, and range-based for
apol (Aleix Pol Gonzalez)
noreply at phabricator.kde.org
Tue Jun 14 13:07:41 UTC 2016
apol added inline comments.
INLINE COMMENTS
> xrandroutput.cpp:258
>
> - Q_FOREACH(const QString &pre, embedded) {
> + for (const QLatin1String &pre : embedded) {
> if (name.toUpper().startsWith(pre)) {
This one is fine, but I wouldn't change from `foreach -> for` as a norm, as it can easily backfire.
REPOSITORY
rLIBKSCREEN KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D1866
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, #plasma
Cc: apol, broulik, graesslin, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160614/63dbea92/attachment-0001.html>
More information about the Plasma-devel
mailing list