[Differential] [Commented On] D1856: more creative output type detection in xrandr backend

sebas (Sebastian Kügler) noreply at phabricator.kde.org
Tue Jun 14 12:34:48 UTC 2016


sebas added inline comments.

INLINE COMMENTS

> graesslin wrote in xrandroutput.cpp:253
> sure you want to use a QStringList? It looks to me like you wanted to have them as QLatin1Strings for the startsWith check. But that doesn't work when converted to QString. So maybe QVector<QLatin1String>?

This code is copied, I left it as-is, just moved it around.

I'll fix the issues with the existing code separately.

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/xrandrtype

REVISION DETAIL
  https://phabricator.kde.org/D1856

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, dvratil
Cc: broulik, graesslin, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160614/1237466f/attachment.html>


More information about the Plasma-devel mailing list