[Differential] [Request, 99 lines] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  To use eglCreateImageKhr for an X11 pixmap we need an EGLDisplay created
  for the same XDisplay as the X11 pixmap. This means if we created an
  EGLDisplay for a GBM device, we are not allowed to load a texture from
  the X11 pixmap and can result in a crash in the driver.
  
  Similar in the nested X11 setup the EGLDisplay is created for the
  rendering window, but the X11 pixmaps are from the Xwayland server KWin
  started. They don't belong to the same windowing system.
  
  This change addresses this problem by moving the loading of X11 pixmaps
  from AbstractEglTexture to EglTexture of the EglOnX11Backend. Thus for
  any usage on a non X11 platform we cannot hit the code path any more.
  In addition the nested X11 platform can indicate that it doesn't support
  it and thus also doesn't go through the code path.

TEST PLAN
  Tested standalone and nested X11 platform

REPOSITORY
  rKWIN KWin

BRANCH
  texture-from-pixmap-x11-only

REVISION DETAIL
  https://phabricator.kde.org/D1857

AFFECTED FILES
  abstract_egl_backend.cpp
  abstract_egl_backend.h
  plugins/platforms/x11/common/eglonxbackend.cpp
  plugins/platforms/x11/common/eglonxbackend.h
  plugins/platforms/x11/windowed/egl_x11_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160614/4bc81394/attachment-0001.html>