[Differential] [Updated, 10 lines] D1839: [Panel] Fix warning and don't cause side-effects in binding
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Mon Jun 13 10:59:29 UTC 2016
broulik updated this revision to Diff 4386.
broulik added a comment.
Use "when" to not mess with the panel length until we have a containment.
Otherwise we would start and briefly have the panel at 0 size which looks ugly. This probably was concealed by the old code just throwing an exception when it tried to access formFactor on null containment
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1839?vs=4379&id=4386
REVISION DETAIL
https://phabricator.kde.org/D1839
AFFECTED FILES
desktoppackage/contents/views/Panel.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160613/82c4f8e8/attachment.html>
More information about the Plasma-devel
mailing list