[Differential] [Request, 125 lines] D1838: Add a prop to toggle the special grouping behavior for tasks in demanding-attention state.
hein (Eike Hein)
noreply at phabricator.kde.org
Mon Jun 13 08:15:25 UTC 2016
hein created this revision.
hein added a reviewer: davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This is needed for subsequent feature work which needs to be able
to turn this off.
This review also includes a number of bug fixes to the model:
- Fix an off-by-one when explicitly breaking a group apart.
- Fix rowCount() returning the value for a top-level item with the same row when called for a group member.
- Fix updating/invalidating persistent indices endRemoveRows() doesn't know how to handle.
- Update data for former parent item ahead of child-reparenting insert when breaking a group apart.
None of these fixes actually matter for the applet view, but
they obviously improve correctness, and will matter for later
work.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1838
AFFECTED FILES
libtaskmanager/taskgroupingproxymodel.cpp
libtaskmanager/taskgroupingproxymodel.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, davidedmundson
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160613/6f32601e/attachment.html>
More information about the Plasma-devel
mailing list