Review Request 128108: update weather applet ui

[Andreas Kainz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/
-----------------------------------------------------------

(Updated June 10, 2016, 10:37 p.m.)


Review request for Plasma and Friedrich W. H. Kossebau.


Changes
-------

only the defined changes

I don't use versions or something else. If you found an issue please let me know. I don't add new stuff only coding issues.


Repository: kdeplasma-addons


Description
-------

the scaling work now better and the pading between the single lines can be smaler (If you make the applet higher you can also have the old line spacing)

it's my first qml change, so ...

on my todo, I'd like to change the powerd by weather.com text color so a secondary gray (bring it a bit more to the background), but I don't know how.


Diffs (updated)
-----

  applets/weather/package/contents/ui/TopPanel.qml 1821f16 
  applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
  applets/weather/package/contents/ui/main.qml d490728 

Diff: https://git.reviewboard.kde.org/r/128108/diff/


Testing
-------

with breeze and breeze dark color scheme on two different pc's. the icons are breeze weather icons (master)


File Attachments
----------------

screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
I hope I had fixed all open issues. I now have only one open issue I could change the linkColor but I can't change the color when there is no link like in noaa
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png


Thanks,

Andreas Kainz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160610/06e6731c/attachment.html>