Review Request 128144: Windecoration KCM theme color

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128144/#review96335
-----------------------------------------------------------




kcmkwin/kwindecoration/qml/Buttons.qml (line 42)
<https://git.reviewboard.kde.org/r/128144/#comment65108>

    this is from the wrong theme.
    
    Even though it's not ideal, we currently have two styles:
    
     - Plasma
    
     - Applications
    
    As this is shown in systemsettings we're using the applications style; which means not using anything from Plasma.
    
    To do so can lead to a "white text on white background" situation. 
    
    What's the bug you're fixing?


other changes look good.

- David Edmundson


On June 9, 2016, 11:16 p.m., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128144/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 11:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> change the button area of the windowdecoration kcm to use the theme colors.
> 
> 
> Diffs
> -----
> 
>   kcmkwin/kwindecoration/qml/Buttons.qml 2e64873 
> 
> Diff: https://git.reviewboard.kde.org/r/128144/diff/
> 
> 
> Testing
> -------
> 
> system settings -> Window Decoration -> Buttons tab used breeze dark color scheme.
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160609/73dbfd15/attachment.html>