Review Request 128089: [Quick Chat] Add context menu for copying text and links

[Kai Uwe Broulik]

> On Juni 7, 2016, 1:20 nachm., Thomas Pfeiffer wrote:
> > Akthough of course I'd prefer being able to actually select text, this is a very helpful workaround for the fact that we cannot have that.
> > 
> > Why do links have the option to open the link in the context menu? That's what left-clicking already does, isn't it?

> Why do links have the option to open the link in the context menu? 

No particular reason, I just mimiced Konsole's window but indeed there clicking a link does nothing, so it needs the entry.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128089/#review96258
-----------------------------------------------------------


On Juni 7, 2016, 12:52 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128089/
> -----------------------------------------------------------
> 
> (Updated Juni 7, 2016, 12:52 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> This allows to copy links by right clicking them and copying individual text snippets to the clipboard.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 1485c4c 
>   chat/org.kde.ktp-chat/contents/ui/TextDelegate.qml ab686a6 
>   chat/qmlplugin/CMakeLists.txt 52e79a0 
>   chat/qmlplugin/htmlhelper.h PRE-CREATION 
>   chat/qmlplugin/htmlhelper.cpp PRE-CREATION 
>   chat/qmlplugin/qmlplugin.cpp 71a6495 
> 
> Diff: https://git.reviewboard.kde.org/r/128089/diff/
> 
> 
> Testing
> -------
> 
> Unfortunately QtQuick has no proper text selection and you can only copy one message at a time, not an entire paragraph from a user, although it looks that way because they're grouped. Better than nothing I suppose.
> 
> 
> File Attachments
> ----------------
> 
> Copy link
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/03/15b0f08e-9a54-46c3-9d87-e817a7dfbef1__Screenshot_20160603_161915.png
> Copy text
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/03/e431324f-de43-4d17-9f65-9f16f5af2f92__Screenshot_20160603_161931.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160609/7874961f/attachment.html>