[Differential] [Request, 51 lines] D1793: [Device Notifier] Be more declarative

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of having a bunch of handlers in various places messing with various settings, try to use declarative bindings where possible.
  
  - Remove separate passive timer, instead re-use the pendingDelegateRemoval property which has its own timer. This way, when a device is unmounted, device notifier stays active until the notification has cleared, however, when the device is yanked out manually, it disappears right away
  - Don't break binding on Plasmoid.active to ensure its state is always proper depending on whether a device or not is present (the linked bug)
  - Create tooltip declaratively rather than imperatively
  
  BUG: 362992
  FIXED-IN: 5.7.0

TEST PLAN
  - Started plasma with no usb stick - initially passive
  - Start plasma with - immediately active
  
  - Plugged in usb stick - got popup with active state
  - Plugged it out - immediately got passive
  - Plugged back in - got popup with active state
  - Mounted and then unmounted - got popup with notification, stayed active until notification cleared

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1793

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160607/908460c6/attachment.html>