Review Request 128052: Improve agenda view in digital-clock applet

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128052/
-----------------------------------------------------------

(Updated June 6, 2016, 10:56 p.m.)


Review request for Plasma, KDE Usability, Martin Klapetek, and Thomas Pfeiffer.


Changes
-------

Updated how the start/end datetime is shown for multi-day events. As Thomas suggested, we show:

* start time if it started yesterday less than 12 hours ago
* start date if it started yesterday more than 12 hours ago or before that
* end time if it ends tomorrow in less than 12 hours
* end date if it ends tomorrow after more than 12 hours or later

The start-date/end-date cases are visible on the screenshots.


@Thomas: I did not implemented the "-" before the end date/time, it throws the thing completely out of alignment and looks very silly. I could theoretically align the start date/time to be aligned with the end date/time, like

      01:00 PM
    - 03:00 PM

But that wastes another pixels on the horizontal space, cutting from the amount of title/description...


Repository: plasma-workspace


Description
-------

I've been working on CalendarEventsPlugin for the digital-clock applet to show events from Akonadi, but it turned out the agenda view in the applet is not really ready to show real-world events yet, so I played around with it for a while this evening...it's nothing fancy, but at least I feel like I can use the agenda view productively now. See screenshots below.


Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/CalendarView.qml fb30c6f 

Diff: https://git.reviewboard.kde.org/r/128052/diff/


Testing
-------


File Attachments (updated)
----------------

Agenda view - before
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/583a3955-76bc-4e3b-8bc2-053c269acf22__calendar-before.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/316644c5-4184-4b6c-bf5f-a86cf25fa5db__calendar1.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/810cb0db-5844-486f-bee9-722a0299e943__calendar2.png
Agenda view - before
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/e73f7249-4ed3-4283-94d2-e92e412262b3__calendar-before.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/966381cf-4a0b-4adc-a68b-ddb9110a9527__calendar1.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/64ddc24b-be06-405e-88f6-868a4bf0f687__calendar2.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/30/5b2cabb7-71dd-4cb4-9054-43426e9c6b14__calendar1.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/30/463fc403-3ffb-4cd4-8a6c-a8bf067db09f__calendar2.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/43f3af18-162b-4600-95ab-b57dd3d98927__calendar1.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/63be822d-17b9-4a6a-8630-29a40bae65b6__calendar2.png


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160606/d4aeb304/attachment-0001.html>