Review Request 128109: Provide demo/preview for checkable menu items too [WIP]

René J.V. Bertin rjvbertin at gmail.com
Mon Jun 6 11:39:49 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128109/
-----------------------------------------------------------

Review request for Plasma.


Repository: oxygen


Description
-------

It's come up that there currently is no "official" preview for how checked menu items are rendered as a function of installed widget style.

This patch explores a straightforward way of doing that via the most exhaustive style preview utility I am aware of, Oxygen's demo app.

This demo already has menus in the MDI preview. The patch makes the layout items checkable and puts them in a QActionGroup so their mutually exclusive nature is taken into account. It also adds a "right to left" non-exclusive checkable item which is linked to the "Left to Right" checkbox in the demo frame.

I looked for an appropriate way to uncheck the Tile/Cascade/Tabbed menu items (= when the user moves or resizes one of the MDI windows) but it seems those events are not available through signals and would thus require subclassing MdiSubWindow .


Diffs
-----

  kstyle/demo/oxygendemodialog.h b296ec7 
  kstyle/demo/oxygendemodialog.cpp 4a742e3 
  kstyle/demo/oxygenmdidemowidget.h eafbeee 
  kstyle/demo/oxygenmdidemowidget.cpp 3e5422e 

Diff: https://git.reviewboard.kde.org/r/128109/diff/


Testing
-------

On Linux and OS X with KF5 5.22.0 and Qt 5.6.0


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160606/593002ba/attachment.html>


More information about the Plasma-devel mailing list