[Differential] [Request, 200 lines] D1773: Introduce an initial state event into Plasma Window protocol
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Mon Jun 6 10:46:05 UTC 2016
graesslin created this revision.
graesslin added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The event is sent to the client once all initial state is transmitted.
This means the client is able to see the PlasmaWindow completely created
and not in the intermediate state with further updates being pushed after
being created.
The client side API is adjusted to emit the windowCreated signal after
the initial state event is received. In addition if the window is already
unmapped, the signal will never be emitted which means the not valid
windows are not exposed to the client at all.
The tests are adjusted to reflect the new reality, which in most cases
just means removing the comment that this needs to be improved.
There is one kind of unrelated change included: when an empty icon is
set, the client side now creates a QIcon() instead of going through
QIcon::fromTheme. This wrong behavior was exposed now by the auto tests.
REPOSITORY
rKWAYLAND KWayland
BRANCH
plasma-window-initial-state
REVISION DETAIL
https://phabricator.kde.org/D1773
AFFECTED FILES
autotests/client/test_plasma_window_model.cpp
autotests/client/test_wayland_windowmanagement.cpp
src/client/plasmawindowmanagement.cpp
src/client/protocols/plasma-window-management.xml
src/server/plasmawindowmanagement_interface.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma, hein
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160606/d143f698/attachment-0001.html>
More information about the Plasma-devel
mailing list