[Differential] [Commented On] D1769: [Service Runner] Don't use KRun::runService

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Mon Jun 6 07:50:36 UTC 2016


davidedmundson added a comment.


  This now matches what Icon is doing, but Kicker is using:
  
    new KRun(QUrl::fromLocalFile(service->entryPath()), 0, true, ...);
  
  This puts the kservice parsing into being done by klauncher/kinit which seems more "right". 
  Does using ->exec() skip the KAuthorised check?
  
  It'll also be even faster as it'll return straight away, this still blocks a tiiiny amount until we roundtrip to kinit.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1769

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, apol, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160606/2dddba61/attachment.html>


More information about the Plasma-devel mailing list