[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Fri Jun 3 10:51:00 UTC 2016


broulik added inline comments.

INLINE COMMENTS

> Panel.qml:29
> +
> +    //onPrefixChanged: adjustBorders();
>      onRepaintNeeded: adjustPrefix();

Dunno if we still need this, ie. if we need a way to signal this back to cpp

> Panel.qml:32
>  
> -    visible: false //adjust borders is run during setup. We want to avoid painting till completed
> +    enabledBorders: containment.enabledBorders
>  

Needs to check for containment being null or else prints warning

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1757

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160603/a125415e/attachment.html>


More information about the Plasma-devel mailing list