[Differential] [Request, 106 lines] D1756: [PanelView] Expose enabled borders as property and also forward it to PanelShadows
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Fri Jun 3 10:48:43 UTC 2016
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
I noticed that panels had borders on all sides and it turns out PanelShadows was never actually told which sides should have shadows. To reduce code duplication I expose the enabled borders as property to the Panel.qml which itself does the same calculation from QML again and does it many times.
TEST PLAN
Moved panels around a bit, didn't notice breakage, but there might be.
I no longer have panel shadows bleeding onto other screens.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1756
AFFECTED FILES
shell/panelshadows.cpp
shell/panelshadows_p.h
shell/panelview.cpp
shell/panelview.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160603/e103579a/attachment.html>
More information about the Plasma-devel
mailing list