[Differential] [Request, 33 lines] D1744: Fix the ignore struts multi-screen handling

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added reviewers: Plasma, apol, lbeltrame.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The checks in Client::adjustedClientArea were a little bit too
  agressive, excluding also valid setups.
  
  This change addresses the regression by keeping the actual intended
  improvements in place.
  
  The check in Client::adjustedClientArea is now only done for the
  special case of desktopArea == area. This ensures that a strut excluding
  a complete screen won't affect the overall workarea.
  
  In addition new checks are introduced in Workspace::updateClientArea.
  When calculating the new sareas a check is performed whether the
  intersection with the adjustedClientArea would result in the sarea
  becoming empty (thus a screen being completely removed). If that's the
  case the geometry is ignored to not exclude a complete screen.
  
  Interestingly I should have noticed that something with the logic is
  odd. As the test case had two commented geometries which we now get.
  
  BUG: 363804

REPOSITORY
  rKWIN KWin

BRANCH
  fix-ignore-struts

REVISION DETAIL
  https://phabricator.kde.org/D1744

AFFECTED FILES
  autotests/wayland/struts_test.cpp
  geometry.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, apol, lbeltrame
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160602/6978538f/attachment.html>