Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes
Kai Uwe Broulik
kde at privat.broulik.de
Thu Jun 2 08:40:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128074/
-----------------------------------------------------------
(Updated June 2, 2016, 10:40 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Daniel Vrátil and Sebastian Kügler.
Changes
-------
Submitted with commit 3cd70aa1cef0b4aab8c13bba049e5b1ccd6ae1ab by Kai Uwe Broulik to branch master.
Repository: libkscreen
Description
-------
Without a valid config in the BackendManager, KScreen::Config::canBeApplied always returns false causing KScreen to ignore any stored config on startup sometimes. Wait until we have a config before telling that the backend is ready.
Diffs
-----
src/backendmanager.cpp 570f575
Diff: https://git.reviewboard.kde.org/r/128074/diff/
Testing
-------
I can now start kded5 from console without it falling back to an "ideal" config.
Didn't do much testing, though. Might have unwanted side-effects.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160602/703159ad/attachment.html>
More information about the Plasma-devel
mailing list