[Differential] [Requested Changes To] D1730: address race condition around setoperation

[graesslin (Martin Gräßlin)]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> daemon.cpp:190
>  {
> +    qCDebug(KSCREEN_KDED) << "QET" << m_changeBlockTimer->isValid() << m_changeBlockTimer->hasExpired(100) << m_changeBlockTimer->elapsed();
> +    if (m_changeBlockTimer->isValid() && !m_changeBlockTimer->hasExpired(100)) {

never call elapsed on a not valid timer! The behavior is undefined.

> daemon.cpp:195
> +        return;
> +    }
>      qCDebug(KSCREEN_KDED) << "Change detected";

I suggest to do the invalidate as I suggested as it frees up resources.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D1730

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, #plasma, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160601/406558eb/attachment.html>