[Differential] [Updated] D1722: Import next-gen libtaskmanager.

hein (Eike Hein) noreply at phabricator.kde.org
Wed Jun 1 06:20:41 UTC 2016


hein marked 18 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> broulik wrote in launchertasksmodel.cpp:125
> coding style: foreach (...)

I don't understand this. You're complaining about the white space or ...? I changed it assuming that was it.

> broulik wrote in taskgroupingproxymodel.cpp:337
> duplicate RemoveQuery

Done, first should have been PrettyDecoded.

> broulik wrote in taskgroupingproxymodel.cpp:371
> constFirst() (new in 5.6)

Changed in a number of places.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160601/c7d00a35/attachment.html>


More information about the Plasma-devel mailing list